Consistently avoid module resolution errors when using `getSymbolAtLocation` by Andarist · Pull Request #58668 · microsoft/TypeScript

Andarist · 2024-05-27T09:09:02Z

…cation`

Andarist · 2024-05-27T09:11:45Z

src/compiler/checker.ts

            Diagnostics.Cannot_find_module_0_Did_you_mean_to_set_the_moduleResolution_option_to_nodenext_or_to_add_aliases_to_the_paths_option
            : Diagnostics.Cannot_find_module_0_or_its_corresponding_type_declarations;
-        return resolveExternalModuleNameWorker(location, moduleReferenceExpression, ignoreErrors ? undefined : errorMessage);
+        return resolveExternalModuleNameWorker(location, moduleReferenceExpression, ignoreErrors ? undefined : errorMessage, ignoreErrors);


This is the core of the fix. It propagates the ignoreErrors and the intention to ignore them is highlighted in the comment here:
https://github.dev/microsoft/TypeScript/blob/af3a61fe4487a92d59f9479aa4249d897b91af14/src/compiler/checker.ts#L1654-L1658

src/compiler/checker.ts

src/testRunner/unittests/programApi.ts

Andarist · 2024-05-27T09:19:01Z

src/testRunner/unittests/tsc/composite.ts

        ],
    });
+
+    verifyTsc({


those are tests related to the referenced issue

tests/baselines/reference/moduleAugmentationGlobal5.js

Andarist · 2024-05-27T09:33:48Z

...ence/tscWatch/resolveJsonModule/incremental-always-prefers-declaration-file-over-document.js

+    "referencedMap": {
+      "./main.ts": [
+        "./data.d.json.ts"
+      ]
+    },


This feels like an improvement - even though there is a resolution error here, it still depends on this file so it should be reflected here. IIRC, there are other instances of something like this - when despite a resolution errors requested modules are listed here.

This reverts commit c69d9cc.

This reverts commit ca9be69.

This reverts commit 908ddd0.

Andarist · 2024-05-31T08:27:16Z

...ference/tscWatch/programUpdates/when-changing-`allowImportingTsExtensions`-of-config-file.js

-[96mb.ts[0m:[93m1[0m:[93m8[0m - [91merror[0m[90m TS5097: [0mAn import path can only end with a '.ts' extension when 'allowImportingTsExtensions' is enabled.
-
-[7m1[0m import "./a.ts";
-[7m [0m [91m       ~~~~~~~~[0m
-
-[[90mHH:MM:SS AM[0m] Found 1 error. Watching for file changes.


I think this error should be reported but currently it was reported here accidentally. It's not consistent with a regular - non-incremental/composite executions. I raised an issue about it here: #58725

FWIW resolving these would be #50394

…nthetic-import

jakebailey · 2024-06-07T07:29:53Z

@typescript-bot test it
@typescript-bot pack this

typescript-bot · 2024-06-07T07:29:57Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results
`pack this`	✅ Started	✅ Results

typescript-bot · 2024-06-07T07:31:32Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/162131/artifacts?artifactName=tgz&fileId=71D5E87C0254083AD9A25080B19F958EEA359780CCE198BDB12841AA1D3452D702&fileName=/typescript-5.6.0-insiders.20240607.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2024-06-07T07:50:51Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2024-06-07T07:58:42Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/58668/merge:

Everything looks good!

typescript-bot · 2024-06-07T08:06:06Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{192,948k (± 0.79%)}	_{193,600k (± 0.91%)}	_~	_192,343k	_195,863k	_{p=0.173 n=6}
_{Parse Time}	_{1.30s (± 0.90%)}	_{1.30s (± 0.58%)}	_~	_1.29s	_1.31s	_{p=0.933 n=6}
_{Bind Time}	_0.72s	_0.72s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.57s (± 0.21%)}	_{9.60s (± 0.47%)}	_~	_9.53s	_9.65s	_{p=0.164 n=6}
_{Emit Time}	_{2.75s (± 0.82%)}	_{2.76s (± 1.04%)}	_~	_2.73s	_2.80s	_{p=0.685 n=6}
_{Total Time}	_{14.34s (± 0.16%)}	_{14.38s (± 0.28%)}	_~	_14.32s	_14.42s	_{p=0.119 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,109	_944,109	_~	_~	_~	_{p=1.000 n=6}
_Types	_407,049	_407,049	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,222,237k (± 0.01%)}	_{1,222,246k (± 0.00%)}	_~	_1,222,198k	_1,222,341k	_{p=0.936 n=6}
_{Parse Time}	_{6.79s (± 0.57%)}	_{6.78s (± 0.57%)}	_~	_6.72s	_6.83s	_{p=0.687 n=6}
_{Bind Time}	_{1.87s (± 0.40%)}	_{1.88s (± 0.22%)}	_~	_1.87s	_1.88s	_{p=0.100 n=6}
_{Check Time}	_{31.29s (± 0.36%)}	_{31.25s (± 0.23%)}	_~	_31.15s	_31.37s	_{p=0.688 n=6}
_{Emit Time}	_{15.22s (± 0.53%)}	_{15.24s (± 0.84%)}	_~	_15.03s	_15.35s	_{p=0.575 n=6}
_{Total Time}	_{55.18s (± 0.31%)}	_{55.15s (± 0.30%)}	_~	_54.94s	_55.38s	_{p=0.688 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,063,474	_2,063,474	_~	_~	_~	_{p=1.000 n=6}
_Types	_905,299	_905,299	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,072,777k (± 0.01%)}	_{2,072,760k (± 0.01%)}	_~	_2,072,576k	_2,072,908k	_{p=0.630 n=6}
_{Parse Time}	_{8.10s (± 0.35%)}	_{8.11s (± 0.28%)}	_~	_8.09s	_8.15s	_{p=0.685 n=6}
_{Bind Time}	_{2.76s (± 0.91%)}	_{2.75s (± 0.81%)}	_~	_2.72s	_2.78s	_{p=0.805 n=6}
_{Check Time}	_{82.47s (± 0.40%)}	_{82.49s (± 0.56%)}	_~	_82.08s	_83.13s	_{p=0.810 n=6}
_{Emit Time}	_{0.16s (± 3.16%)}	_{0.16s (± 3.16%)}	_~	_0.16s	_0.17s	_{p=1.000 n=6}
_{Total Time}	_{93.50s (± 0.36%)}	_{93.52s (± 0.53%)}	_~	_93.06s	_94.22s	_{p=0.689 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,424	_1,230,497	_{+73 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,178	_261,204	_{+26 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,351,921k (± 0.04%)}	_{2,351,800k (± 0.04%)}	_~	_2,350,729k	_2,353,077k	_{p=0.936 n=6}
_{Parse Time}	_{4.97s (± 0.95%)}	_{4.98s (± 0.91%)}	_~	_4.95s	_5.07s	_{p=0.810 n=6}
_{Bind Time}	_{1.90s (± 0.40%)}	_{1.89s (± 0.67%)}	_~	_1.87s	_1.90s	_{p=0.301 n=6}
_{Check Time}	_{34.15s (± 0.29%)}	_{34.03s (± 0.33%)}	_~	_33.89s	_34.15s	_{p=0.173 n=6}
_{Emit Time}	_{2.61s (± 1.72%)}	_{2.62s (± 3.04%)}	_~	_2.53s	_2.75s	_{p=0.810 n=6}
_{Total Time}	_{43.64s (± 0.17%)}	_{43.53s (± 0.39%)}	_~	_43.38s	_43.84s	_{p=0.093 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,230,424	_1,230,497	_{+73 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_261,178	_261,204	_{+26 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,427,402k (± 0.05%)}	_{2,427,814k (± 0.02%)}	_~	_2,427,190k	_2,428,580k	_{p=0.471 n=6}
_{Parse Time}	_{5.20s (± 0.95%)}	_{5.19s (± 1.58%)}	_~	_5.09s	_5.30s	_{p=0.748 n=6}
_{Bind Time}	_{1.69s (± 0.79%)}	_{1.68s (± 0.70%)}	_~	_1.66s	_1.69s	_{p=0.241 n=6}
_{Check Time}	_{34.58s (± 0.13%)}	_{34.51s (± 0.39%)}	_~	_34.33s	_34.69s	_{p=0.378 n=6}
_{Emit Time}	_{2.67s (± 3.04%)}	_{2.67s (± 0.64%)}	_~	_2.65s	_2.70s	_{p=1.000 n=6}
_{Total Time}	_{44.15s (± 0.27%)}	_{44.06s (± 0.42%)}	_~	_43.82s	_44.30s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_259,181	_259,182	_{+1 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_105,173	_105,173	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{428,839k (± 0.01%)}	_{428,815k (± 0.01%)}	_~	_428,781k	_428,843k	_{p=0.230 n=6}
_{Parse Time}	_{4.10s (± 0.62%)}	_{4.06s (± 0.43%)}	_{-0.04s (- 0.85%)}	_4.04s	_4.09s	_{p=0.034 n=6}
_{Bind Time}	_{1.63s (± 1.43%)}	_{1.63s (± 1.39%)}	_~	_1.60s	_1.66s	_{p=0.568 n=6}
_{Check Time}	_{22.36s (± 0.35%)}	_{22.36s (± 0.35%)}	_~	_22.27s	_22.46s	_{p=0.872 n=6}
_{Emit Time}	_{1.72s (± 1.68%)}	_{1.72s (± 1.74%)}	_~	_1.68s	_1.76s	_{p=0.871 n=6}
_{Total Time}	_{29.80s (± 0.31%)}	_{29.77s (± 0.26%)}	_~	_29.65s	_29.84s	_{p=0.421 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,754k (± 0.02%)}	_{369,820k (± 0.03%)}	_~	_369,637k	_369,925k	_{p=0.298 n=6}
_{Parse Time}	_{3.45s (± 0.81%)}	_{3.45s (± 0.68%)}	_~	_3.42s	_3.49s	_{p=0.570 n=6}
_{Bind Time}	_{1.94s (± 0.98%)}	_{1.94s (± 0.84%)}	_~	_1.92s	_1.96s	_{p=0.744 n=6}
_{Check Time}	_{19.35s (± 0.31%)}	_{19.42s (± 0.28%)}	_~	_19.34s	_19.49s	_{p=0.077 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.75s (± 0.35%)}	_{24.80s (± 0.25%)}	_~	_24.75s	_24.89s	_{p=0.335 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,851,240	_2,851,240	_~	_~	_~	_{p=1.000 n=6}
_Types	_967,181	_967,181	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,023,304k (± 0.00%)}	_{3,023,299k (± 0.00%)}	_~	_3,023,247k	_3,023,394k	_{p=0.689 n=6}
_{Parse Time}	_{13.96s (± 0.29%)}	_{13.92s (± 0.24%)}	_~	_13.88s	_13.97s	_{p=0.126 n=6}
_{Bind Time}	_{4.17s (± 0.24%)}	_{4.16s (± 0.29%)}	_~	_4.15s	_4.18s	_{p=0.490 n=6}
_{Check Time}	_{76.71s (± 2.67%)}	_{75.31s (± 2.46%)}	_~	_73.80s	_77.73s	_{p=0.230 n=6}
_{Emit Time}	_{21.20s (± 8.72%)}	_{22.51s (± 8.25%)}	_~	_20.11s	_24.01s	_{p=0.093 n=6}
_{Total Time}	_{116.03s (± 0.35%)}	_{115.90s (± 0.21%)}	_~	_115.67s	_116.34s	_{p=0.810 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_266,415	_266,415	_~	_~	_~	_{p=1.000 n=6}
_Types	_108,580	_108,580	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{411,445k (± 0.01%)}	_{411,426k (± 0.01%)}	_~	_411,371k	_411,474k	_{p=0.689 n=6}
_{Parse Time}	_{3.87s (± 0.67%)}	_{3.84s (± 0.77%)}	_~	_3.80s	_3.87s	_{p=0.106 n=6}
_{Bind Time}	_{1.67s (± 1.03%)}	_{1.67s (± 0.72%)}	_~	_1.66s	_1.69s	_{p=0.934 n=6}
_{Check Time}	_{17.08s (± 0.27%)}	_{17.06s (± 0.21%)}	_~	_17.03s	_17.12s	_{p=0.296 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{22.62s (± 0.28%)}	_{22.57s (± 0.15%)}	_~	_22.53s	_22.62s	_{p=0.146 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_526,436	_526,436	_~	_~	_~	_{p=1.000 n=6}
_Types	_179,425	_179,425	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{464,208k (± 0.04%)}	_{464,080k (± 0.08%)}	_~	_463,585k	_464,453k	_{p=0.810 n=6}
_{Parse Time}	_{3.13s (± 0.77%)}	_{3.15s (± 0.58%)}	_~	_3.13s	_3.17s	_{p=0.252 n=6}
_{Bind Time}	_{1.18s (± 0.46%)}	_{1.19s (± 0.82%)}	_~	_1.18s	_1.21s	_{p=0.201 n=6}
_{Check Time}	_{18.10s (± 0.60%)}	_{18.08s (± 0.53%)}	_~	_17.89s	_18.14s	_{p=0.470 n=6}
_{Emit Time}	_0.00s	_{0.00s (±244.70%)}	_~	_0.00s	_0.01s	_{p=0.405 n=6}
_{Total Time}	_{22.42s (± 0.42%)}	_{22.42s (± 0.39%)}	_~	_22.25s	_22.49s	_{p=1.000 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-06-07T09:14:26Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/58668/merge:

Everything looks good!

jakebailey · 2024-06-20T18:07:27Z

This appears to be out of date with main.

...ference/tscWatch/programUpdates/when-changing-`allowImportingTsExtensions`-of-config-file.js

…nthetic-import

Andarist added 3 commits May 26, 2024 17:42

Consistently avoid module reoslution errors when using `getSymbolAtLo…

a821a2b

…cation`

fixed missing module resolution errors

908ddd0

fixed errors on specifier-less imports

ca9be69

typescript-bot assigned iisaduan May 27, 2024

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label May 27, 2024